backport New Notebook UI configuration to 1.8 #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry pick of 3ec71e9 from main) * Enable configuration of New Notebook UI This commit adds configuration for: * the default number of GPUs and the GPUs available * the default PodDefaults selected * the Toleration configurations available * the Affinity configurations available These configurations are enabled through newly exposed charm configs. These configs are lightly validated to ensure they're valid yaml, but not validated enough to ensure things like Tolerations or Affinities are proper Kubernetes yaml (cherry picked from commit 3ec71e9)
…ons (#361) Previously, the spawner_ui_config.yaml was rendered with empty strings and lists being rendered as null values in the configuration file. For example if the GPU vendors list was empty and the default vendor was `""`, the config file would have (shown truncated): ``` gpus: value: vendor: vendors: ``` whereas jupyter web app expected: ``` gpus: value: vendor: "" vendors: [] ``` This commit updates the template to ensure we always output the correct empty values. Closes #360 (cherry picked from commit 211a37b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of:
to
track/1.8. See #345 for testing instructions