Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kf 4327 feat port jupyter notebook rocks to 1.7 #300

Closed
wants to merge 7 commits into from
Closed

Kf 4327 feat port jupyter notebook rocks to 1.7 #300

wants to merge 7 commits into from

Conversation

i-chvets
Copy link
Contributor

@i-chvets i-chvets commented Sep 13, 2023 •
edited
Loading

Description

Jupyter Notebook ROCK images need to be integrated into track/1.7 to provide more secure images.

Summary of changes:

  • Updated spawner UI config with references to published ROCK images.

i-chvets and others added 4 commits March 28, 2023 09:30
@i-chvets @ca-scribner
[KF-1471] fix: add default value for pipelines (#221)
5417821 
* fix: add default value for pipelines
canonical/kfp-operators#159

Fixes #159 

Summary of changes:
- Added back default value for pipelines access.
- Added tests for default values of pipelines access and images for 1.7
  release.
- Modified code to check for mindspore image only not version.

---------

Co-authored-by: Andrew Scribner <[email protected]>
Merge branch 'track/1.7' of github.com:canonical/notebook-operators i…
2dbbe2b 
…nto track/1.7
Merge branch 'track/1.7' of github.com:canonical/notebook-operators i…
2d25c66 
…nto track/1.7
feat: updated spawner with references to rocks
999bf02 
Summary of chanages:
- Updated spawner UI config with references to published ROCK images.
@i-chvets i-chvets requested a review from a team as a code owner September 13, 2023 21:09
@i-chvets i-chvets marked this pull request as draft September 13, 2023 21:09
@i-chvets i-chvets marked this pull request as ready for review September 14, 2023 13:13
@i-chvets i-chvets changed the title Kf 4327 feat port jupyter notebook rocks to 1.7 (WIP) Kf 4327 feat port jupyter notebook rocks to 1.7 Sep 14, 2023
DnPlas
DnPlas reviewed Sep 15, 2023
View reviewed changes
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @i-chvets , since we are upgrading soon to 1.8.0, does it make sense to have this change approved and merged?

We are about to merge #302, which updates CRDs and container images.

@i-chvets
Copy link
Contributor Author

Thanks @i-chvets , since we are upgrading soon to 1.8.0, does it make sense to have this change approved and merged?

We are about to merge #302, which updates CRDs and container images.

@DnPlas This is for track/1.7 and should not affect 1.8 work. For 1.8 we will have similar PR for main.

@DnPlas
Copy link
Contributor

DnPlas commented Sep 18, 2023

Thanks @i-chvets , since we are upgrading soon to 1.8.0, does it make sense to have this change approved and merged?
We are about to merge #302, which updates CRDs and container images.

@DnPlas This is for track/1.7 and should not affect 1.8 work. For 1.8 we will have similar PR for main.

Gotcha, okay. Makes sense, then. Just a comment, your branch seems to be dirty, it has some commits that are already in the track/1.7 branch, you may want to do a cleanup before we can approve and merge.

@i-chvets i-chvets mentioned this pull request Sep 18, 2023
Merged
@i-chvets
Copy link
Contributor Author

i-chvets commented Sep 18, 2023 •
edited
Loading

@DnPlas Created clean PR #303
Closing this PR in favour of #303
There was some left over commits in this PR, new clean one was required.

@i-chvets i-chvets closed this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DnPlas DnPlas DnPlas left review comments

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@i-chvets @DnPlas