Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyter-ui individual integration tests are flaky #359

Open
DnPlas opened this issue Apr 22, 2024 · 3 comments
Open

jupyter-ui individual integration tests are flaky #359

DnPlas opened this issue Apr 22, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@DnPlas
Copy link
Contributor

DnPlas commented Apr 22, 2024

Bug Description

The test_notebook_image_selector test case fails to assert the correct image values.

To Reproduce

Run the CI for this repository. I have only been able to see this failing in the track/1.8 Github branch, though.

Environment

The PR and merge CI.

Relevant Log Output

File "/home/runner/work/notebook-operators/notebook-operators/charms/jupyter-ui/tests/integration/test_charm.py", line 111, in test_notebook_image_selector
    assert actual_images == expected_images
AssertionError: assert ['kubeflownot...ython:v1.8.0'] == ['vscodeimage...vscodeimage2']
  At index 0 diff: 'kubeflownotebookswg/codeserver-python:v1.8.0' != 'vscodeimage1'
  Right contains one more item: 'vscodeimage2'
  Full diff:
  - ['vscodeimage1', 'vscodeimage2']
  + ['kubeflownotebookswg/codeserver-python:v1.8.0']

Additional Context

Some CI runs:

@DnPlas DnPlas added the bug Something isn't working label Apr 22, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5595.

This message was autogenerated

@ca-scribner
Copy link
Contributor

I saw this recently too, but haven't looked into it. Not sure if something has changed or ... ?

Its possible I broke something with the recent jupyter configuration PR too, but I'm not sure how

@DnPlas
Copy link
Contributor Author

DnPlas commented Apr 23, 2024

Your recent changes definitely removed this test case, but since ch:track/1.8 still has them, I don't think anything your did recently could've affected the branch. We need to investigate as the publish job is currently stuck because of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants