Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Machine listing filters no longer reflected in URL #1028

Closed
squidsoup opened this issue Apr 24, 2020 · 0 comments · Fixed by #1032
Closed

Machine listing filters no longer reflected in URL #1028

squidsoup opened this issue Apr 24, 2020 · 0 comments · Fixed by #1032
Assignees
@Caleb-Ellis
Labels
Bug 🐛 Priority: High
Milestone
Iteration 20-18 /...

Comments

@squidsoup
Copy link
Contributor

Describe the bug
Machine listing filters were previously reflected in the URL, but recent refactoring may have broken that. When addressing this, please make sure we have a good test to ensure filter changes also update the querystring.

maas-ui version
11c9c60

MAAS version
n/a

To Reproduce
Steps to reproduce the behavior:

  1. Add a filter on the machine listing
  2. Note that the url no longer updates

Screenshots
If applicable, add screenshots to help explain your problem.
image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Caleb-Ellis Caleb-Ellis

Labels
Bug 🐛 Priority: High
Projects
None yet
Milestone
Iteration 20-18 / Apr 27 - May 8
Development

Successfully merging a pull request may close this issue.

Fix filter accordion URL update regression. Caleb-Ellis/maas-ui
3 participants
@squidsoup @Caleb-Ellis @cristinadresch