Handle None being returned for ingresses

[motjuste]

svc.status.loadBalancer.ingress has been observed to return None in certain situations and leads to failure of the ingress-relation-created hook. This change handles the None and treats the situation as if no ingresses are present.

[motjuste]

I am happy to write tests for this, but would need guidance to get started.

[orfeas-k]

Hi @motjuste, does this PR try to resolve #287?

[motjuste]

Hi @motjuste, does this PR try to resolve #287?

Not intentionally, but yes, I also faced an issue that was because of not handling the None response.

[orfeas-k]

That's great. Thank you for taking the time to try and fix this. Could you add a unit test then that replicates the situtation as described in the issue #287 (comment)? This way, we 'll make sure that the fix you 've sent makes what we expect it to.

You could do that by adding another fixture for the specific case and then adding it as a parameter to the tests we already have (first and second).

[motjuste]

Thanks for pointing me to the tests. I'll update the PR with them.

[motjuste]

Added a new mock fixture (sorry for the verbose name, suggestions welcome), and then I added it to the two parameterised tests.

I can't seem to check the CI outputs attached to this PR below. I am new to GitHub Actions ... is there a way for me to get the test running in GitHub without having to set everything up on my laptop?

[orfeas-k]

Hi @motjuste, we discussed this issue with our team internally and decided that we should start allowing PRs from external forks to run workflows (issue canonical/bundle-kubeflow#764). We will look to implement this in the near future but at the moment, this is not possible (for security reasons as mentioned in the issue).

For that reason, we will hold this PR until that issue is resolved, so we can properly test and merge it. Once again, thank you for taking the time to contribute to our project.