Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove public-url configuration from integration tests and add required relation #487

Closed
DnPlas opened this issue Jul 31, 2024 · 2 comments
Closed

Remove public-url configuration from integration tests and add required relation #487

DnPlas opened this issue Jul 31, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@DnPlas
Copy link
Contributor

DnPlas commented Jul 31, 2024

Context

The oidc-gatekeeper and dex-auth charms do not have this configuration option anymore. It is still set in the integration tests for this repo, so we should remove it and add the appropriate relation so those charms are active and idle and don't block the CI.

What needs to get done

  1. Remove the public-url configuration option from integration tests
  2. Add the dex-oidc-config relation between oidc and dex charms

Definition of Done

The CI is not blocked because of the extra config option.
@DnPlas DnPlas added the enhancement New feature or request label Jul 31, 2024
@syncronize-issues-to-jira Syncronize issues to Jira
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6076.

This message was autogenerated

DnPlas added a commit that referenced this issue Jul 31, 2024
@DnPlas
tests: remove public-url config and add dex-oidc-config relation
4c8b2c2 
The public-url configuration option has been replaced by
a relation between dex-auth and oidc-gatekeeper. Because of that,
configuring this option is not required anymore, and in fact if kept,
can cause errors as it won't be recognised by Juju anymore.
This commit removes the extra configuration from the integration tests.

Part of #487
DnPlas added a commit that referenced this issue Jul 31, 2024
@DnPlas
tests: remove public-url config and add dex-oidc-config relation
1c8c2bb 
The public-url configuration option has been replaced by
a relation between dex-auth and oidc-gatekeeper. Because of that,
configuring this option is not required anymore, and in fact if kept,
can cause errors as it won't be recognised by Juju anymore.
This commit removes the extra configuration from the integration tests.

Part of #487
This was referenced Jul 31, 2024
Merged
Merged
DnPlas added a commit that referenced this issue Jul 31, 2024
@DnPlas
tests: remove public-url config and add dex-oidc-config relation
5d1118c 
The public-url configuration option has been replaced by
a relation between dex-auth and oidc-gatekeeper. Because of that,
configuring this option is not required anymore, and in fact if kept,
can cause errors as it won't be recognised by Juju anymore.
This commit removes the extra configuration from the integration tests.

Part of #487
@DnPlas DnPlas mentioned this issue Jul 31, 2024
Merged
DnPlas added a commit that referenced this issue Jul 31, 2024
@DnPlas
tests: remove public-url config and add dex-oidc-config relation
40e1814 
The public-url configuration option has been replaced by
a relation between dex-auth and oidc-gatekeeper. Because of that,
configuring this option is not required anymore, and in fact if kept,
can cause errors as it won't be recognised by Juju anymore.
This commit removes the extra configuration from the integration tests.

Part of #487
@DnPlas DnPlas mentioned this issue Jul 31, 2024
Merged
DnPlas added a commit that referenced this issue Jul 31, 2024
@DnPlas
tests: remove public-url config and add dex-oidc-config relation
3c689b0 
The public-url configuration option has been replaced by
a relation between dex-auth and oidc-gatekeeper. Because of that,
configuring this option is not required anymore, and in fact if kept,
can cause errors as it won't be recognised by Juju anymore.
This commit removes the extra configuration from the integration tests.

Part of #487
@DnPlas DnPlas mentioned this issue Jul 31, 2024
Merged
DnPlas added a commit that referenced this issue Jul 31, 2024
@DnPlas
tests: remove public-url config and add dex-oidc-config relation
d9c934d 
The public-url configuration option has been replaced by
a relation between dex-auth and oidc-gatekeeper. Because of that,
configuring this option is not required anymore, and in fact if kept,
can cause errors as it won't be recognised by Juju anymore.
This commit removes the extra configuration from the integration tests.

Part of #487
DnPlas added a commit that referenced this issue Jul 31, 2024
@DnPlas
tests: remove public-url config and add dex-oidc-config relation
08e8915 
The public-url configuration option has been replaced by
a relation between dex-auth and oidc-gatekeeper. Because of that,
configuring this option is not required anymore, and in fact if kept,
can cause errors as it won't be recognised by Juju anymore.
This commit removes the extra configuration from the integration tests.

Part of #487
This was referenced Jul 31, 2024
Closed
Merged
DnPlas added a commit that referenced this issue Jul 31, 2024
@DnPlas
tests: remove public-url config and add dex-oidc-config relation (#488)
a9347bf 
The public-url configuration option has been replaced by
a relation between dex-auth and oidc-gatekeeper. Because of that,
configuring this option is not required anymore, and in fact if kept,
can cause errors as it won't be recognised by Juju anymore.
This commit removes the extra configuration from the integration tests.

Part of #487
DnPlas added a commit that referenced this issue Jul 31, 2024
@DnPlas
tests: remove public-url config and add dex-oidc-config relation (#489)
d74befd 
The public-url configuration option has been replaced by
a relation between dex-auth and oidc-gatekeeper. Because of that,
configuring this option is not required anymore, and in fact if kept,
can cause errors as it won't be recognised by Juju anymore.
This commit removes the extra configuration from the integration tests.

Part of #487
DnPlas added a commit that referenced this issue Aug 1, 2024
@DnPlas
tests: remove public-url config and add dex-oidc-config relation (#494)
5ed3d13 
The public-url configuration option has been replaced by
a relation between dex-auth and oidc-gatekeeper. Because of that,
configuring this option is not required anymore, and in fact if kept,
can cause errors as it won't be recognised by Juju anymore.
This commit removes the extra configuration from the integration tests.

Part of #487
DnPlas added a commit that referenced this issue Aug 1, 2024
@DnPlas
tests: remove public-url config and add dex-oidc-config relation (#492)
bca0ab3 
The public-url configuration option has been replaced by
a relation between dex-auth and oidc-gatekeeper. Because of that,
configuring this option is not required anymore, and in fact if kept,
can cause errors as it won't be recognised by Juju anymore.
This commit removes the extra configuration from the integration tests.

Part of #487
DnPlas added a commit that referenced this issue Aug 1, 2024
@DnPlas
tests: remove public-url config and add dex-oidc-config relation (#491)
fea1698 
The public-url configuration option has been replaced by
a relation between dex-auth and oidc-gatekeeper. Because of that,
configuring this option is not required anymore, and in fact if kept,
can cause errors as it won't be recognised by Juju anymore.
This commit removes the extra configuration from the integration tests.

Part of #487
DnPlas added a commit that referenced this issue Aug 6, 2024
@DnPlas
tests: remove public-url config and add dex-oidc-config relation (#490)
1e04f3c 
The public-url configuration option has been replaced by
a relation between dex-auth and oidc-gatekeeper. Because of that,
configuring this option is not required anymore, and in fact if kept,
can cause errors as it won't be recognised by Juju anymore.
This commit removes the extra configuration from the integration tests.

Part of #487
@DnPlas
Copy link
Contributor Author

DnPlas commented Aug 14, 2024

Track branches from 1.18 -> 1.22 now have the fix. Closing this issue, as there is nothing else to do.

@DnPlas DnPlas closed this as completed Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DnPlas