From 9122ccfbf7f0cf6f39f98b52d36963d309ade69a Mon Sep 17 00:00:00 2001 From: Manos Vlassis <57320708+mvlassis@users.noreply.github.com> Date: Tue, 3 Sep 2024 16:01:10 +0300 Subject: [PATCH] Pin charmcraft channel to `3.1/stable` (#541) * Pin charmcraft channel * Add comment above the pinning to link to the proper issue * Pin to 3.x instead of 3.1 which doesn't exist as a track --- .github/workflows/integrate.yaml | 6 ++++-- .github/workflows/publish.yaml | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/integrate.yaml b/.github/workflows/integrate.yaml index ba7fbc9b..52db99fd 100644 --- a/.github/workflows/integrate.yaml +++ b/.github/workflows/integrate.yaml @@ -72,7 +72,8 @@ jobs: channel: ${{ matrix.microk8s-versions }} microk8s-addons: "dns hostpath-storage rbac metallb:10.64.140.43-10.64.140.49" juju-channel: 3.4/stable - charmcraft-channel: latest/candidate + # Pinned to 3.x/stable due to https://github.com/canonical/charmcraft/issues/1845 + charmcraft-channel: 3.x/stable - name: Run integration tests run: | @@ -139,7 +140,8 @@ jobs: channel: ${{ matrix.microk8s-versions }} microk8s-addons: "dns hostpath-storage rbac metallb:10.64.140.43-10.64.140.49" juju-channel: 3.4/stable - charmcraft-channel: latest/candidate + # Pinned to 3.x/stable due to https://github.com/canonical/charmcraft/issues/1845 + charmcraft-channel: 3.x/stable - name: Run observability integration tests run: | diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml index 98d1eefc..bb39aeee 100644 --- a/.github/workflows/publish.yaml +++ b/.github/workflows/publish.yaml @@ -91,4 +91,5 @@ jobs: charm-path: ${{ matrix.charm-path }} channel: ${{ steps.parse-inputs.outputs.destination_channel }} tag-prefix: ${{ steps.parse-inputs.outputs.tag_prefix }} - charmcraft-channel: latest/candidate + # Pinned to 3.x/stable due to https://github.com/canonical/charmcraft/issues/1845 + charmcraft-channel: 3.x/stable