Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcomings of sortCandidates #269

Open
cole-miller opened this issue Sep 7, 2023 · 0 comments
Open

Shortcomings of sortCandidates #269

cole-miller opened this issue Sep 7, 2023 · 0 comments
Labels
Bug Confirmed to be a bug

Comments

@cole-miller
Copy link
Contributor

@ktsakalozos correctly pointed out during review for #268 that calling sortCandidates throws away information about node roles, so that we no longer consistently prefer standbys for promotion over spares. We should fix that.
@cole-miller cole-miller added the Bug Confirmed to be a bug label Sep 7, 2023
@cole-miller cole-miller removed their assignment Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Confirmed to be a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cole-miller