Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidecar rewrite: envoy #71

Closed
misohu opened this issue Jan 29, 2024 · 3 comments · Fixed by #75
Closed

Sidecar rewrite: envoy #71

misohu opened this issue Jan 29, 2024 · 3 comments · Fixed by #75
Labels
enhancement New feature or request

Comments

@misohu
Copy link
Member

misohu commented Jan 29, 2024

Context

We rewrite all of our charms using the sidecar with base charm pattern instead of the old podspec.

What needs to get done

Rewrite the charm using sidecar with base charm pattern.

Definition of Done

Charm is rewritten with sidecar with base charm pattern.
All of the tests are rewritten and passing.

@misohu misohu added the enhancement New feature or request label Jan 29, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5257.

This message was autogenerated

@DnPlas
Copy link
Contributor

DnPlas commented Feb 5, 2024

When we work on this task, we have to have in mind that we will need to migrate the k8s-service relation interface from its SDI implementation to the newer one handled by a library. See canonical/mlops-libs#2 for more information about the library and what it entails.

Context

Based on the proposal in canonical/mlops-libs#2 and the changes that are going to be introduced in canonical/mlmd-operator#71 we'll need to update the k8s-service relation interface handling this charm.

What needs to get done

Replace the SDI component that handles this relation interface with the library that is going to be created in canonical/mlops-libs#2

Definition of Done

  1. The SDI implementation is replaced with the library proposed in Create k8s_service_info library that replaces the SDI k8s-service interface mlops-libs#2
  2. There is a working upgrade path from a previous version of this charm

@ca-scribner
Copy link
Contributor

This'll take a bit more effort than usual because of canonical/charmed-kubeflow-chisme#89. We need to solve canonical/charmed-kubeflow-chisme#89 before we can write Envoy using the CharmReconciler because we need to push a config file to the container that requires inputs from other components.

I have a working solution to this that wont be a huge effort, but it still adds maybe an extra half a day or so to the rewrite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

3 participants