Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically include external_hostname & s3_cdn_url in CORS origin (cors_origin) #218

Open
hloeung opened this issue Apr 15, 2024 · 0 comments

Comments

@hloeung
Copy link

hloeung commented Apr 15, 2024

Enhancement Proposal

Hi,

I think it would be nice to automatically include the configured external_hostname & s3_cdn_url in the CORS origin (cors_origin).

Currently, cors_origin is configurable so we can set that to include both, but it would be nice if the charm would automatically do this for us. This reduces the chance of human error where updating the other settings would make it less of an issue or miss updating cors_origin.

For external_hostname, I think it would need to take into account force_https to see if it should add https:// or just http://.

For s3_cdn_url, it would add it as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant