From 445d5146e20ca6157c59a15112d8f81ac4230203 Mon Sep 17 00:00:00 2001 From: Alex Lowe Date: Fri, 26 Jul 2024 14:30:12 -0400 Subject: [PATCH] fix(type): fix ProviderService.get_base annotation (#398) Fixes #397 Co-authored-by: Callahan --- craft_application/services/provider.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/craft_application/services/provider.py b/craft_application/services/provider.py index c3391b22..38607d32 100644 --- a/craft_application/services/provider.py +++ b/craft_application/services/provider.py @@ -144,7 +144,7 @@ def get_base( base_name: bases.BaseName | tuple[str, str], *, instance_name: str, - **kwargs: bool | str | None, + **kwargs: bool | str | pathlib.Path | None, ) -> craft_providers.Base: """Get the base configuration from a base name. @@ -164,7 +164,7 @@ def get_base( # this only applies to our Buildd images (i.e.; Ubuntu) self.packages.extend(["gpg", "dirmngr"]) return base_class( - alias=alias, + alias=alias, # pyright: ignore[reportArgumentType] craft-providers annotations are loose. compatibility_tag=f"{self._app.name}-{base_class.compatibility_tag}", hostname=instance_name, snaps=self.snaps,