Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using "Parametrizing fixtures" for sample_plans fixtures in mocked-plans tests #356

Closed
rgildein opened this issue Apr 4, 2024 · 2 comments
Closed

Consider using "Parametrizing fixtures" for sample_plans fixtures in mocked-plans tests #356

rgildein opened this issue Apr 4, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@rgildein
Copy link
Contributor

rgildein commented Apr 4, 2024

In original #334 introducing the mocked-plans, we discuss that maybe it would be good to use Parametrizing fixtures for sample_plans fixture.
Like this each test will run for each yaml file, what can be an issue if we want to create custom tests (e.g. just for one hypervisor or with some hypervisors not being empty).
@rgildein rgildein added the enhancement New feature or request label Apr 4, 2024
@rgildein rgildein mentioned this issue Apr 4, 2024
Merged
@Pjack
Copy link

Pjack commented Oct 18, 2024

Refactoring has become a low priority, as Caracal will be the final release of charmed-openstack.

@Pjack Pjack closed this as completed Oct 18, 2024
@syncronize-issues-to-jira Syncronize issues to Jira
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/SOLENG-789.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Pjack @rgildein