Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loose talisker #65

Merged
merged 2 commits into from
Jan 23, 2023
Merged

loose talisker #65

merged 2 commits into from
Jan 23, 2023

Conversation

nottrobin
Copy link
Contributor

@nottrobin nottrobin commented Jan 14, 2023 •
edited
Loading

We need the latest Talisker for 3.10 compatibility.

We should stay on the latest Talisker going forward, as Talisker is central and controlled by Canonical.

QA

Run ubuntu.com with python 3.10 somehow. Check it works with this branch by putting this in requirements.txt:

git+https://github.com/nottrobin/canonicalwebteam.flask-base@loose-talisker#egg=canonicalwebteam.flask-base

@nottrobin nottrobin requested a review from jkfran January 16, 2023 10:18
@nottrobin nottrobin marked this pull request as ready for review January 16, 2023 10:23
edlerd
edlerd approved these changes Jan 23, 2023
View reviewed changes
Copy link

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this with the new design.ubuntu.com locally to build and run the production image and it works nicely now with a jammy base image with python 3.10!

@nottrobin nottrobin merged commit 27370a7 into canonical:main Jan 23, 2023
@nottrobin nottrobin deleted the loose-talisker branch January 23, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd edlerd approved these changes

@jkfran jkfran Awaiting requested review from jkfran

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nottrobin @edlerd