-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't take in to account having a newsletter signup card #115
Comments
This is also now affecting jaas.ai |
You can now configure the number of articles you want to pull per page. That should solve this issue, unless we only want tho show the signup card in the first page. |
This seems to be fixed. |
If the solution is "Have a newsletter signup form on every page" this isn't fixed. |
@tbille @jpmartinspt this is still an issue on snapcraft.io and ubuntu.com (maybe on others as well). The last post on the first page is showed as the first post on the second page. |
@carkod, yeath this is still an issue. snapcraft is missing "KDE snaps performance revving up": |
The third item on https://snapcraft.io/blog is replaced by the newsletter sign up form. The blog module should be able to adjust it's offsets to accomodate an extra item as having a newsletter signup is a common pattern (https://ubuntu.com/blog), currently it simply replaces a blog post!?
See for the messy way I implemented it in snapcraft: https://github.com/canonical-web-and-design/snapcraft.io/pull/2119/files#diff-4e6fc427b5a0fb3861c0230dcb245caeL46
The text was updated successfully, but these errors were encountered: