Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't take in to account having a newsletter signup card #115

Open
Lukewh opened this issue Aug 15, 2019 · 7 comments
Open

Doesn't take in to account having a newsletter signup card #115

Lukewh opened this issue Aug 15, 2019 · 7 comments

Comments

@Lukewh
Copy link

Lukewh commented Aug 15, 2019

The third item on https://snapcraft.io/blog is replaced by the newsletter sign up form. The blog module should be able to adjust it's offsets to accomodate an extra item as having a newsletter signup is a common pattern (https://ubuntu.com/blog), currently it simply replaces a blog post!?

See for the messy way I implemented it in snapcraft: https://github.com/canonical-web-and-design/snapcraft.io/pull/2119/files#diff-4e6fc427b5a0fb3861c0230dcb245caeL46

@Lukewh
Copy link
Author

Lukewh commented Sep 6, 2019

This is also now affecting jaas.ai

@jpmartinspt
Copy link
Contributor

You can now configure the number of articles you want to pull per page. That should solve this issue, unless we only want tho show the signup card in the first page.

@tbille
Copy link
Contributor

tbille commented May 6, 2020

This seems to be fixed.

@tbille tbille closed this as completed May 6, 2020
@Lukewh
Copy link
Author

Lukewh commented May 6, 2020

If the solution is "Have a newsletter signup form on every page" this isn't fixed.

@Lukewh Lukewh reopened this May 6, 2020
@solazio
Copy link
Contributor

solazio commented Aug 6, 2020

@tbille @jpmartinspt this is still an issue on snapcraft.io and ubuntu.com (maybe on others as well). The last post on the first page is showed as the first post on the second page.

@pmahnke pmahnke removed this from the Iteration 19-36 / Sep 2nd - 13th milestone Dec 9, 2020
@carkod
Copy link
Contributor

carkod commented May 9, 2022

it's been almost 2 years. @Lukewh @jkfran , do guys still see this issue?

@Lukewh
Copy link
Author

Lukewh commented May 10, 2022

@carkod, yeath this is still an issue. snapcraft is missing "KDE snaps performance revving up":

Snapcraft.io with newsletter sign up:
image

Ubuntu.com without:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants