-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate multipass docs pages #1440
Migrate multipass docs pages #1440
Conversation
d706125
to
f2956eb
Compare
f2956eb
to
fdbadfe
Compare
search_action="https://canonical.com/multipass/docs/search", | ||
siteSearch="https://canonical.com/multipass/docs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
search_action="/multipass/docs/search",
siteSearch="/multipass/docs",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because /multipass/docs isn't there on canonical.com yet, so it's gonna return 404
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to QA it locally and running the search on https://0.0.0.0:8002/microstack/docs/search?q=testing&siteSearch=%2Fmicrostack%2Fdocs
Is there no other way to QA search besides on prod?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can test it locally, given you have an API key in your env (SEARCH_API_KEY)
for the search module.
PS., you gotta remove the domain from urls in BOTH the document.html and search-results.html file (you missed the search_action and siteSearch in document.html) for it to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch thanks, I updated document.html
! I do have the SEARCH_API_KEY
in my local environment, the search just doesn't return any results
1457e12
to
ab94073
Compare
Co-authored-by: Muhammad Ali <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Need to add new doc site to Google Custom Search Engine (https://github.com/canonical/canonicalwebteam.search?tab=readme-ov-file#new-sites)
Done
QA
Issue / Card
Fixes WD-16619
Screenshots
[if relevant, include a screenshot]