Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AKS/EKS action is failing when called via workflow_dispatch #1124

Open
mvlassis opened this issue Oct 25, 2024 · 2 comments · May be fixed by #1125
Open

AKS/EKS action is failing when called via workflow_dispatch #1124

mvlassis opened this issue Oct 25, 2024 · 2 comments · May be fixed by #1125
Labels
bug Something isn't working

Comments

@mvlassis
Copy link
Contributor

Bug Description

Here is a relevant run of the failed action.

To Reproduce

  • Trigger a call on the AKS or EKS action via workflow dispatch

Environment

  • Branch: main

Relevant Log Output

The workflow is not valid. .github/workflows/deploy-to-eks.yaml (Line: 57, Col: 25): Unrecognized named-value: 'jobs'. Located at position 80 within expression: fromJSON(needs.preprocess-input.outputs.processed_bundle_versions) || fromJSON(jobs.generate-bundle-versions-on-schedule.outputs.bundle_versions) .github/workflows/deploy-to-eks.yaml (Line: 57, Col: 25): Unexpected value '${{ fromJSON(needs.preprocess-input.outputs.processed_bundle_versions) || fromJSON(jobs.generate-bundle-versions-on-schedule.outputs.bundle_versions) }}'

Additional Context

No response

@mvlassis mvlassis added the bug Something isn't working label Oct 25, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6500.

This message was autogenerated

@mvlassis
Copy link
Contributor Author

After a bit of troubleshooting with @orfeas-k, we concluded the following:

  • A job can only reference a job that it needs, otherwise sequential execution is not guaranteed.
  • It is not possible in Github Actions to have a conditional needs for a job. This means that we cannot have the deploy-ckf job depend on either the job that runs on schedule or the one that runs on workflow dispatch.
  • Thus, with the current structure we have to change the above 2 jobs to run always, which defeats the purpose of having 2 separate jobs.
  • We have decided it makes more sense to have a single job for preprocessing, and put the conditionals inside the run section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant