Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE] The comments explaining the use of existingSecret settings are incorrect #762

Open
Tracked by #1
daniel-ewing opened this issue Jul 7, 2023 · 2 comments
Labels
kind/issue Unidentified issue, it could be a bug, misconfig, or anything in between

Comments

@daniel-ewing
Copy link

Describe the issue:

The comments explaining the use of existingSecret settings are incorrect for all settings like: global.identity.auth.[componentName].existingSecret. See, for example values.yaml#L128-L129, which states:

        # Identity.auth.connectors.existingSecret can be used to use an own existing secret. If not set a random secret is generated.
        # The existing secret should contain an `connectors-secret` field, which will be used as secret for the Identity-Connectors communication.

Actual behavior:

If used this way, global.identity.auth.[componentName].existingSecret contains the actual value of the secret stored in the [componentName]-secret field of an auto-generated secret with the name [deploymenyName]-[componentName]-secret.

Expected behavior:

The comment should accurately explain the behavior described above and the values.yaml should also explain that if you want to provide the name of an existing secret that contains a [componentName]-secret field, the correct syntax is global.identity.auth.[componentName].existingSecret.name

How to reproduce:

Try it.

Logs:

Not relevant.

Environment:

  • Platform: minikube
  • Chart version: 8.2.6
@daniel-ewing daniel-ewing added the kind/issue Unidentified issue, it could be a bug, misconfig, or anything in between label Jul 7, 2023
@proxyvert
Copy link

hi @daniel-ewing, I have the same issue #760

@floric
Copy link

floric commented Jul 10, 2023

See #760 (comment) :) good luck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/issue Unidentified issue, it could be a bug, misconfig, or anything in between
Projects
None yet
Development

No branches or pull requests

4 participants