Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show_diff parameter to postfix::conffile #226

Merged
merged 1 commit into from
Aug 23, 2019

Conversation

treydock
Copy link
Contributor

No description provided.

@anarcat
Copy link

anarcat commented Aug 20, 2019

why would you want to disable this? this would be easier to accept if it didn't change the default (which is true)

@treydock
Copy link
Contributor Author

I changed default to true. This is useful if a site decides to define a file with a password and globally enables show_diff in configs for reports. Our reports go out via email so have to take care to ensure diffs don't contain passwords.

    postfix::conffile { 'ldap-aliases.cf':
      options   => {
        'server_host'      => $ldap_server_host,
        'search_base'      => $ldap_base,
        'query_filter'     => '(uid=%s)',
        'result_attribute' => 'mail',
        'version'          => '3',
        'bind'             => 'yes',
        'bind_dn'          => $ldap_bind_dn,
        'bind_pw'          => $ldap_bind_pw,
      },
      show_diff => false,
    }

@raphink raphink merged commit 7407878 into voxpupuli:master Aug 23, 2019
@raphink raphink added the enhancement New feature or request label Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants