From 4eb55c2baba5e14db748995ed38baf1db0e637cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A9phane=20Brunner?= Date: Wed, 18 Jul 2018 15:05:52 +0200 Subject: [PATCH] Activate and fix spell --- .travis.yml | 1 + buildtools/check-no-goog.sh | 9 --------- contribs/gmf/examples/authentication.js | 2 +- contribs/gmf/src/layertree/TreeManager.js | 2 +- contribs/gmf/src/less/popover.less | 4 ++-- docs/guidelines.md | 2 +- docs/how_to_migrate_from_2.2_to_2.3.md | 4 ++-- src/Popover.js | 2 +- test/spec/data/wmtsCapabilities.js | 18 +++++++++--------- 9 files changed, 18 insertions(+), 26 deletions(-) delete mode 100755 buildtools/check-no-goog.sh diff --git a/.travis.yml b/.travis.yml index 5d88d8de202c..52e3527a7544 100644 --- a/.travis.yml +++ b/.travis.yml @@ -56,6 +56,7 @@ script: - make check-examples-checker # Unit tests - make test +- make spell # Webpack build of ngeo/gmf examples and gmf apps - if [ "${TRAVIS_PULL_REQUEST}" = false ]; then export NODE_ENV=production; fi - make examples-hosted diff --git a/buildtools/check-no-goog.sh b/buildtools/check-no-goog.sh deleted file mode 100755 index afcbc78aa2d6..000000000000 --- a/buildtools/check-no-goog.sh +++ /dev/null @@ -1,9 +0,0 @@ -#!/bin/sh - -# Any call to the goog library except the followings are forbidden -echo "Checking use of goog library..." -if grep --include '*.js' -Rn "goog\." src contribs examples | grep -E -v 'goog.provide|goog.require|goog.module|goog.asserts|goog.exportSymbol|goog.exportProperty' -then - echo "Found forbidden uses." - return 1 -fi diff --git a/contribs/gmf/examples/authentication.js b/contribs/gmf/examples/authentication.js index 84a8e21a39cc..67340dd6b88f 100644 --- a/contribs/gmf/examples/authentication.js +++ b/contribs/gmf/examples/authentication.js @@ -29,7 +29,7 @@ exports.module.constant('angularLocaleScript', '../build/angular-locale_{{locale exports.MainController = function(gettextCatalog) { /** * A password validator that check if the password as: - * - A minimal length of 8 characteres. + * - A minimal length of 8 characters. * - At least one lowercase letter. * - At least one Uppercase letter. * - At least one digit. diff --git a/contribs/gmf/src/layertree/TreeManager.js b/contribs/gmf/src/layertree/TreeManager.js index 7f95422ff4a7..23f4c74e2b3b 100644 --- a/contribs/gmf/src/layertree/TreeManager.js +++ b/contribs/gmf/src/layertree/TreeManager.js @@ -498,7 +498,7 @@ exports.prototype.refreshFirstLevelGroups_ = function(themes) { } }); - // Readd the firstlevelgroups. + // Re add the firstlevelgroups. this.setFirstLevelGroups(nodesToRestore); // Wait that Angular has created the layetree, then update the permalink. diff --git a/contribs/gmf/src/less/popover.less b/contribs/gmf/src/less/popover.less index 25353df7fd45..6e59d90d5c83 100644 --- a/contribs/gmf/src/less/popover.less +++ b/contribs/gmf/src/less/popover.less @@ -10,7 +10,7 @@ .popover-content { ul { margin-bottom: 0; - /* fix issue with IE11 not sizing correcly the popover box */ + /* fix issue with IE11 not sizing correctly the popover box */ min-width: 180px; } @@ -41,7 +41,7 @@ margin-left: @half-app-margin; display: inline-block; max-width: @popover-action-max-width - @half-app-margin; - /* fix issue with IE11 not sizing correcly the popover box */ + /* fix issue with IE11 not sizing correctly the popover box */ padding: 0; } } diff --git a/docs/guidelines.md b/docs/guidelines.md index f1fa0e71e1a1..7569f28626eb 100644 --- a/docs/guidelines.md +++ b/docs/guidelines.md @@ -74,7 +74,7 @@ With Webpack, some things have changed between the current ngeo 2.3 version, and ## AngularJS names -Be as logical as possble. In the previous example, the AngularJS name should be `ngeoExampleSearch`. For +Be as logical as possible. In the previous example, the AngularJS name should be `ngeoExampleSearch`. For a service in `contribs/gmf/src/sample/MyService.js`, the name must be `GmfSampleMyservice`. Don't change a name after it's chosen. Because that change the html in the code of all user of ngeo ! diff --git a/docs/how_to_migrate_from_2.2_to_2.3.md b/docs/how_to_migrate_from_2.2_to_2.3.md index 68684221da81..4bead7053080 100644 --- a/docs/how_to_migrate_from_2.2_to_2.3.md +++ b/docs/how_to_migrate_from_2.2_to_2.3.md @@ -78,7 +78,7 @@ It can help to see how `component`, `service`, `factory`, etc. are made in ngeo Note for GeoMapFish: Your application main controllers (files in `static-ngeo/js/.js`). Are also concerned. -But as the build expects to find the interface name in the 'goog.provide', you must potentialy rename +But as the build expects to find the interface name in the 'goog.provide', you must potentially rename your file to match the interface name. Example: you have a `ngeodesktop` interface, that means that your file must be named `ngeodesktop.js` and the file must provide `_ngeodesktop`. You may have to exceptionnaly adapt this line in your @@ -284,7 +284,7 @@ these values to the module of your controller like this: moduleValue('myValueForThePrint': 'b'); // etc. - // You can assign all contant and value to your main module. + // You can assign all constant and value to your main module. // The only exception is for the 'angularLocaleScript' because it must be loaded first. // It must be provided like that: var gmfAbstractAppControllerModule = angular.module('GmfAbstractAppControllerModule'); diff --git a/src/Popover.js b/src/Popover.js index 8c1c905a2cd1..1b10a6b5453f 100644 --- a/src/Popover.js +++ b/src/Popover.js @@ -67,7 +67,7 @@ exports.prototype.setMap = function(map) { if (map) { const contentEl = this.contentEl_; - // wait for the overlay to be rendered in the map before poping over + // wait for the overlay to be rendered in the map before popping over window.setTimeout(() => { $(element) .popover({ diff --git a/test/spec/data/wmtsCapabilities.js b/test/spec/data/wmtsCapabilities.js index bab91808e9c9..463755c2713d 100644 --- a/test/spec/data/wmtsCapabilities.js +++ b/test/spec/data/wmtsCapabilities.js @@ -4,20 +4,20 @@ const exports = '' + '' + '' + - 'Koordinates Labs' + + 'Coordinates Labs' + 'OGC WMTS' + '1.0.0' + '' + '' + - 'Koordinates' + - '' + + 'Coordinates' + + '' + '' + '' + '' + '' + '' + '' + - '' + + '' + '' + '' + 'KVP' + @@ -30,7 +30,7 @@ const exports = '' + '' + '' + '' + - '' + + '' + '' + '' + 'KVP' + @@ -64,9 +64,9 @@ const exports = '' + '' + 'EPSG:3857' + '' + - '' + - '' + - '' + + '' + + '' + + '' + '' + '' + 'GoogleMapsCompatible' + @@ -278,7 +278,7 @@ const exports = '' + '' + '' + '' + - '' + + '' + '';