Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] automatic build container images #180

Open
Nelsi11120 opened this issue Feb 6, 2023 · 2 comments
Open

[BUG] automatic build container images #180

Nelsi11120 opened this issue Feb 6, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Nelsi11120
Copy link

Describe the bug
It seems like the automatic build and push container image does not work anymore and some manual triggering is required: https://github.com/Cameri/nostream/actions/runs/4108512046

Expected behavior
An automatic build and push of the container images to avoid doing it manually

@Nelsi11120 Nelsi11120 added the bug Something isn't working label Feb 6, 2023
@Nelsi11120 Nelsi11120 changed the title [BUG] [BUG] automatic build container images Feb 6, 2023
@antonleviathan
Copy link
Contributor

Also looks like we need to upgrade from node 12 to 16 for GH actions:

Build and push container image
Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: docker/login-action@f054a8b539a109f9f41c372932f1ae047eff08c9, docker/metadata-action@98669ae865ea3cffbcbaa878cf57c20bbf1c6c38, docker/build-push-action@ad44023a93711e3deb337508980b4b5e9bcdc5dc. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

@alaznem
Copy link

alaznem commented Feb 24, 2023

If the automatic build of container images bug is resolved, I'll update caprover/one-click-apps#874.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants