Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reference location handling by specifying the correct start range #193

Open
lhein opened this issue Nov 26, 2018 · 2 comments
Open

Comments

@lhein
Copy link
Collaborator

lhein commented Nov 26, 2018

see #192 comment of @apupier :

  • the current end character is the same than the start one. Was it a problem with previous implementation searching in same file? if yes, can you create an issue to improve that? If not, might worth adding a check on position end in test and improve it.
    example of result:
[Trace - 3:23:43 PM] Received response 'textDocument/references - (25)' in 15ms.
Result: [
    {
        "uri": "file:///c%3A/Users/Aurelien%20Pupier/Desktop/camel4.xml",
        "range": {
            "start": {
                "line": 5,
                "character": 40
            },
            "end": {
                "line": 5,
                "character": 40
            }
        }
    }
]
@apupier apupier changed the title Improve reference location handling Improve reference location handling by specifying the correct end range Jul 12, 2019
@apupier apupier changed the title Improve reference location handling by specifying the correct end range Improve reference location handling by specifying the correct start range Jul 12, 2019
@apupier
Copy link
Member

apupier commented Jul 15, 2019

it smells the issue to come from Camel itself. To be investigated more

@apupier
Copy link
Member

apupier commented Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants