Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding issues with non-ascii characters in units #513

Open
markushofmeister opened this issue Dec 7, 2022 · 2 comments · Fixed by #466
Open

Encoding issues with non-ascii characters in units #513

markushofmeister opened this issue Dec 7, 2022 · 2 comments · Fixed by #466
Assignees
Labels
bug Something isn't working infra-timeseries Infrastructure issues related to time series representation and handling (incl. forecasting) infra-vis Infrastructure issues relating to the visualisation framework.

Comments

@markushofmeister
Copy link
Collaborator

There are reported issues with encoding of special characters using Blazegraph, i.e. Blazegraph claims to use utf-8 encoding while actually using iso-8859-1 (details: blazegraph/database#224).

This causes issues when instantiating non-ascii strings, e.g. symbols for units. This is relevant for the AverageQuareMetrePriceEstimation as well as PropertyValueEstimation agents where we use £ as symbol for poundSterling; however, there are also unit symbols defined within the ontology of units of measure, which are affected, e.g. °, °C, µg

Proper encoding (potential solution see here) shall be ensured when 1) uploading data into Blazegraph (@markushofmeister) as well as when 2) retrieving data for visualisation (@mdhillman)

This should also fix the issue observed earlier, e.g. AirQuality agent #227

@markushofmeister markushofmeister added bug Something isn't working infra-vis Infrastructure issues relating to the visualisation framework. infra-timeseries Infrastructure issues related to time series representation and handling (incl. forecasting) labels Dec 7, 2022
@markushofmeister markushofmeister pinned this issue Dec 7, 2022
@markushofmeister markushofmeister unpinned this issue Dec 7, 2022
@markushofmeister markushofmeister linked a pull request Dec 7, 2022 that will close this issue
@mdhillman
Copy link
Collaborator

This should now be resolved in v3.3.4 of the DTVF (already hosted online). Please note however, that you will need to add a charset="UTF-8" tag to the import statement of the DTVF script in your index.html file (the examples have been updated to reflect this).

@markushofmeister
Copy link
Collaborator Author

I just observed the following behaviour for the latest version of the DTVF (but also applicable to previous versions):

When referencing the online JS and CSS resources in the index.html file, the visualisation renders special characters nicely (figure 1):

<script src="https://kg.cmclinnovations.com/cdn/dtvf/3.7.0/dtvf.min.js" charset="UTF-8"></script>
<link href="https://kg.cmclinnovations.com/cdn/dtvf/3.7.0/dtvf.min.css" rel="stylesheet" />

However, when copying the JS and CSS file content from https://kg.cmclinnovations.com/cdn/dtvf/ into local files and referencing them, again styling issues exist (figure 2)

<script src="./dtvf.min.js" charset="UTF-8"></script>
<link href="./dtvf.min.css" rel="stylesheet" />

image
image

@markushofmeister markushofmeister removed their assignment Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working infra-timeseries Infrastructure issues related to time series representation and handling (incl. forecasting) infra-vis Infrastructure issues relating to the visualisation framework.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants