Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Document API design guidelines #104

Closed
shilpa-padgaonkar opened this issue Nov 3, 2022 · 4 comments
Closed

Document API design guidelines #104

shilpa-padgaonkar opened this issue Nov 3, 2022 · 4 comments

Comments

@shilpa-padgaonkar
Copy link
Contributor

To track #96

@shilpa-padgaonkar
Copy link
Contributor Author

After merge of PR96, this issue will be closed

@eric-murray
Copy link
Contributor

Reflecting comments I made in the PR to keep this issue up to date, Vodafone would like to see the following changes to the current proposal:

  • Inclusion of HTTP status code in any error JSON response (following the approach taken in IETF 7807). This can be optional, and it is accepted that it is not definitive, but for information / post-processing purposes only.
  • Filtering notation for >, >=, <, <= should be either replaced by, or at least allow, the TMF notation.

Otherwise, we are happy with the proposed design guidelines.

@jordonezlucena
Copy link
Contributor

jordonezlucena commented Nov 10, 2022

Reflecting comments as for #96, the request for changes proposed by VF are acceptable for us. We have updated the .md file accordingly.

@shilpa-padgaonkar
Copy link
Contributor Author

PR has been merged.

Documentation and related images has been moved to the documentations directory as already clarified with @jordonezlucena and @RubenBG7 . Approved and merged doc can be found here https://github.com/camaraproject/WorkingGroups/blob/main/Commonalities/documentation/API-design-guidelines.md

Closing issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants