Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make response properties required #96

Closed
fernandopradocabrillo opened this issue Mar 15, 2024 · 4 comments · Fixed by #97
Closed

Make response properties required #96

fernandopradocabrillo opened this issue Mar 15, 2024 · 4 comments · Fixed by #97
Assignees

Comments

@fernandopradocabrillo
Copy link
Collaborator

Problem description
Make response properties "latestSimChange" and "swapped" required since they will always be returned

@bigludo7
Copy link
Collaborator

Hello @fernandopradocabrillo
Are we sure for latestSimChange as this is not the outcome of #16 ?

My apologies if I missed a conversation within the team to agreed on this. Not a blocker for me but wanting to be sure we have agreement.
cc @trehman-gsma

@fernandopradocabrillo
Copy link
Collaborator Author

Hi @bigludo7
I assume this was the agreed outcome since we haven't had any new update and Toyeeb's summary pointed in that direction. I missed that meeting but there seemed to be a consensus.
From TEF we have actually implement in this direction using the null as preferred option.

@bigludo7
Copy link
Collaborator

Hello @fernandopradocabrillo
But option 2 of the #16 is:

# 2 - an empty body returned because latestSimChange is an optional attribute
{

}

I'm fine to remove this option but probably let's wait a formal discussion in next meeting - wdyt?

@fernandopradocabrillo
Copy link
Collaborator Author

Hello @bigludo7
Sure, let's discuss on the next meeting. Maybe I was too fast in assuming the outcome, the empty body option is feasable for us too, I just thought it was out of the table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants