Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with @check_sim_swap_6_no_sim_swap scenario #154

Closed
bigludo7 opened this issue Oct 8, 2024 · 1 comment · Fixed by #159
Closed

Issue with @check_sim_swap_6_no_sim_swap scenario #154

bigludo7 opened this issue Oct 8, 2024 · 1 comment · Fixed by #159
Assignees

Comments

@bigludo7
Copy link
Collaborator

bigludo7 commented Oct 8, 2024

Problem description
Doing the test I have an issue with this scenario:

  @check_sim_swap_6_no_sim_swap
  Scenario: Check that the response shows that the SIM has not been swapped
    Given the request header "Authorization" is set to a valid access token from which a phone number connected to the Operator's network can be deducted
    And the SIM for this phone number has never been swapped
    When the request "checkSimSwap" is sent
    Then the response status code is 200
    And the value of response property "$.swapped" == false

Indeed, we consider that: New subscription is considered as a SIM swap as well in the yaml so for the test must be reworked accordingly.
Suppose a new line was activated Oct8th at 4pm
If I make a query Oct9th at 4pm

  • I expect true if maxAge is set to 36
  • I expect false if maxAge is set to 12

Expected behavior
First get @fernandopradocabrillo feedback :)

Alternative solution

Additional context

@fernandopradocabrillo
Copy link
Collaborator

@bigludo7 you are right, this test does not cover all the cases, I'll create a PR to detail it a bit more and include a new one to cover both cases.

  1. No swap when providing maxAge
  2. No swap when using default maxAge

Thanks for bringing it up! I'll update the WIP device swap accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants