-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplification of Device object - short term solution #300
Comments
For the attention of @camaraproject/quality-on-demand_maintainers |
This doesn't account for instances where the access_token applies to multiple devices. While this approach may cover some use cases, it doesn't cover all scenarios and could cause extra complication instead of simplifying the device identifier. Standard error handling, such a returning a list of all devices associated with the access_token along with unique identifiers could resolve this. My earlier comment to this effect in the commonalities thread. camaraproject/Commonalities#171 (comment) |
Could you please share the use case where 3 legged flow is used to get the access_token but it is also applicable to multiple devices (I assume by devices you mean device object identifier - e.g. msisdn, ip, network access identifier). The |
My concern is that I cannot get a 3-legged access token if I only know the public and private IP address of the device, because this is not a Why is this an issue? Because the public and private IP addresses can be mapped directly to parameters for the call to the NEF, whereas the access token, or identifiers that can be associated with the access token, cannot. So ruling out identifying the device by public / private IP addresses makes the implementation more complex. I'd be happier with this proposal if |
Not all 3-legged access tokens may identify always a single device, so we cannot simplify it as "do not send The case that @eric-murray points out for public and private addresses, is one of the latest. While passing an public_ip and port, or a phone number is covered. It would be a discussion for ICM if adding the case for public and private addresses in the login hint is an option to cover it as well. Regarding the removal of |
Discussion results from https://wiki.camaraproject.org/display/CAM/2024-06-14+Quality+on+Demand+-+Meeting+Minutes:
|
camaraproject/Commonalities#233 has been merged and will be part of Commonalities v0.4.0, therefore we need to adapt the quality-on-demand.yaml accordingly:
|
Closed by creating #313 |
Problem description
Commonalities discussed the topic and proposed the short term solution (for the coming meta-release) summarized in camaraproject/Commonalities#171 (comment) :
Reviewing and providing the feedback on the impact of the proposed solution on this subproject was suggested by the TSC.
Possible evolution
Review the proposed changes before Commonalities meeting on 10.06. camaraproject/Commonalities#171
Alternative solution
Review the PR related to camaraproject/Commonalities#171 (should be created soon)
Additional context
Initial proposal of text explaining using access token information to identify the target device of the API request: camaraproject/Commonalities#171 (comment)
Dedicated meeting summary:
https://wiki.camaraproject.org/display/CAM/2024-05-23+-+Commonalities+Ad-Hoc+Meeting+-+Device+Object+review
The text was updated successfully, but these errors were encountered: