Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Authorization and authentication part accordingly to ICM #65

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

bigludo7
Copy link
Collaborator

What type of PR is this?

Add one of the following kinds:

  • documentation

What this PR does / why we need it:

Update Authorization and Authentication document part accordingly to ICM

Which issue(s) this PR fixes:

Fixes #56

Special notes for reviewers:

Changelog input

 release-note
-Update Authorization and authentication documentation part

Additional documentation

This section can be blank.

docs

Update Authorization and authentication accordingly to ICM
Copy link

github-actions bot commented Jun 12, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.02s
✅ OPENAPI spectral 1 0 1.62s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.72s
✅ YAML yamllint 1 0 0.37s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

updated megeLinter bugs
Copy link
Collaborator

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bigludo7
I understand that you are aligning with the proposal made here right?: camaraproject/IdentityAndConsentManagement#168

I am not against it and I can see that my collegue left the LGTM, but it hasn't been merge yet

should we proceed or should we wait just in case?

@bigludo7
Copy link
Collaborator Author

Hi @fernandopradocabrillo
We have to wait I guess. I've prepared the PR as it was agreed by most of the people.

@fernandopradocabrillo fernandopradocabrillo self-requested a review June 12, 2024 14:48
Copy link
Collaborator

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fernandopradocabrillo
Copy link
Collaborator

Hi @fernandopradocabrillo We have to wait I guess. I've prepared the PR as it was agreed by most of the people.

@bigludo7
well we didn't have to wait long, it has already been merge

@bigludo7 bigludo7 merged commit dd933bc into main Jun 13, 2024
1 check passed
@bigludo7 bigludo7 deleted the bigludo7-patch-1 branch June 13, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align securitySchemes and Auth description with commonalities and ICM
2 participants