Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

403 error update to add a new error and aligning with the guidelines #18

Closed
monamok opened this issue Feb 1, 2023 · 2 comments
Closed

Comments

@monamok
Copy link
Collaborator

monamok commented Feb 1, 2023

Reviewing the API and having in mind that we suppose that the phone number that is used to be compared with the received phone number from input is deducted from token, I think it's a good idea to include a new error in the post MWC version, so these cases could be handled.
This error will be used when the phone number cannot be deducted from access token context. Here you can find the PR.

@monamok
Copy link
Collaborator Author

monamok commented Feb 2, 2023

The guideline for errors has been changed today and now status is an integer instead of a string:

camaraproject/WorkingGroups#143
camaraproject/WorkingGroups#145

This change will be also included in the same PR.

@monamok monamok changed the title 403 error update to add a new error 403 error update to add a new error and aligning with the guidelines Feb 3, 2023
@monamok
Copy link
Collaborator Author

monamok commented Feb 23, 2023

Merged

@monamok monamok closed this as completed Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant