Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify case sensitivity of parameter names and values #221

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

eric-murray
Copy link
Collaborator

What type of PR is this?

  • documentation

What this PR does / why we need it:

The CAMARA Security and Interoperability profile does not clarify whether parameter names and values are case sensitive.

It is proposed to adopt the RFC 6749 convention that parameter names and values are case sensitive unless otherwise stated.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

None

Changelog input

 release-note
 - Add document convention that parameter names and values are case-sensitive unless otherwise stated

Additional documentation

None

@AxelNennker
Copy link
Collaborator

Specifications are specifications. If we define e.g. the "tel:" prefix for the login_hint format then that is the prefix.
No other interpretations. Neither "TEL:" nor "Tel:" nor "tEL:" are valid values because the spec specifies "tel:" and nothing else.

@eric-murray
Copy link
Collaborator Author

Specifications are specifications. If we define e.g. the "tel:" prefix for the login_hint format then that is the prefix. No other interpretations. Neither "TEL:" nor "Tel:" nor "tEL:" are valid values because the spec specifies "tel:" and nothing else.

Sure. And this statement, which other standards feel the need to include, unambiguously clarifies this.

@AxelNennker
Copy link
Collaborator

I am trying to avoid repeating standards.
I have no idea how anybody can interpret the specification of e.g. login_hint "tel:" prefix that e.g "Tel:" is conforming to that specification.

I think the "clarification" this PR provides is very unneeded. You do not have to be an "expert" to read our spec and conclude that e.g. only "tel:" is a valid prefix.

If we go there that we start stating the obvious we end up with documents that are harder to understand because now e.g. OpenId Provider implementers have to read the OIDC core standard plus our document.

But, of course, if the group feels it helps then we can add this one sentence.

@AxelNennker AxelNennker merged commit 016c730 into camaraproject:main Nov 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation spring25-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants