Polygon area type added #195
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlurien
reviewed
May 21, 2024
| @@ -342,6 +349,33 @@ components: | |||
| longitude: 7.10066 | |||
| radius: 50000 | |||
|
|
|||
| Polygon: | |||
There was a problem hiding this comment.
For coherence, we should use same schema that we already have defined for location-retrieval: https://github.com/camaraproject/DeviceLocation/blob/main/code/API_definitions/location-retrieval.yaml#L289, which is very similar, but uses boundary and maxItems is 15
There was a problem hiding this comment.
Thanks. The change is done.
There was a problem hiding this comment.
Thanks, we have to conclude the discussion in the issue #194 before deciding on the PR
|
Converted to Draft until we resolve the discussion in #194. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Geofences should support polygon type areas. Circle type is rarely used as geofence. Usually a geofence describes a shape of an (often human built) geographical object like factories, buildings, city and country areas.
Which issue(s) this PR fixes:
Fixes #194
Special notes for reviewers:
Changelog input