Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align security scope with guideline #193

Closed
bigludo7 opened this issue May 7, 2024 · 1 comment · Fixed by #191
Closed

Align security scope with guideline #193

bigludo7 opened this issue May 7, 2024 · 1 comment · Fixed by #191

Comments

@bigludo7
Copy link
Collaborator

bigludo7 commented May 7, 2024

Problem description
As described in recent merged PR177 in commonalities we have to update the security part, openId defined scope in geofencing-subscriptions yaml.

for GET we must have:

Expected behaviorcamaraproject/Commonalities#177

For GET & GET {id} we must have

security:
        - openId:
              - geofencing-subscriptions:read

for DELETE:

security:
        - openId:
              - geofencing-subscriptions:delete

For POST

security:
        - openId:
              - geofencing-subscriptions:org.camaraproject.geofencing.v0.area-entered:create
              - geofencing-subscriptions:org.camaraproject.geofencing.v0.area-left:create

Alternative solution

Additional context
@maxl2287 probably for you as you maintain this yaml ;)

@jlurien
Copy link
Collaborator

jlurien commented May 8, 2024

@bigludo7, if API is renamed to geofencing-subscriptions, should we have to rename as well events to org.camaraproject.geofencing-subscriptions.v0.area-...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants