Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geofencing API - Add "format: uri" to notificationUrl #118

Closed
patrice-conil opened this issue Nov 17, 2023 · 3 comments · Fixed by #202
Closed

Geofencing API - Add "format: uri" to notificationUrl #118

patrice-conil opened this issue Nov 17, 2023 · 3 comments · Fixed by #202
Assignees
Labels
correction Fall24 Meta-release Fall24

Comments

@patrice-conil
Copy link

Problem description
To have a strong typed notificationUrl, add a format constraint on type.
This will simplify implementation and clarify usage.

    NotificationUrl:
      type: string
      format: uri
      example: "https://application-server.com"
      description: https callback address where the event notification must be POST-ed
@jlurien
Copy link
Collaborator

jlurien commented Nov 17, 2023

Hi @patrice-conil, I see this is not applied to other APIs dealing with subscriptions, such as DeviceStatus and SimSwap notifications. This should be something to be agreed transversely.

@patrice-conil
Copy link
Author

Hi @patrice-conil, I see this is not applied to other APIs dealing with subscriptions, such as DeviceStatus and SimSwap notifications. This should be something to be agreed transversely.

Thanks @jlurien, I will therefore suggest doing it in commonalities each time we can specify the format of the field.

@maxl2287
Copy link
Contributor

maxl2287 commented Jun 17, 2024

Hi @patrice-conil,

with the latest subscription-model changes, the newly called sink will have a format: url:

sink:
          type: string
          format: url
          description: The address to which events shall be delivered using the selected protocol.
          example: "https://endpoint.example.com/sink"

see PR #202:
https://github.com/camaraproject/DeviceLocation/pull/202/files#diff-ca27481523133fde153d65b5b9d153f2f7746eeb477fa1f057312ff9eb33f185R357-R361

Would that fit as a solution for your issue here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction Fall24 Meta-release Fall24
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants