Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on non-mandatory error statuses #374

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rartych
Copy link
Collaborator

@rartych rartych commented Jan 13, 2025

What type of PR is this?

  • correction

What this PR does / why we need it:

Clarification proposed in the issue discussion.

Which issue(s) this PR fixes:

Fixes #355

Does this PR introduce a breaking change?

  • Yes
  • No

Special notes for reviewers:

The discussion in #355 concludes to keep the error definitions in CAMARA_common.yaml.
Adding comments to each error schema (saying if it is mandatory) can be considered.

Changelog input

Added clarification on non-mandatory error statuses

Additional documentation

This section can be blank.

docs

Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should errors 405, 415, 500, 501, 502, 503, 504 be listed in CAMARA_common.yaml
4 participants