Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String pattern added to x-correlator scheme #373

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rartych
Copy link
Collaborator

@rartych rartych commented Jan 13, 2025

What type of PR is this?

  • correction

What this PR does / why we need it:

String pattern added to x-correlator scheme to improve security and inline with current recommendation for string parameters.
The proposed pattern covers recommended UUID strings and the length of 55 allows to use strings similar to traceparent from Trace Context.

CAMARA_common.yaml was updated accordingly.

Which issue(s) this PR fixes:

Fixes #352

Does this PR introduce a breaking change?

  • Yes
  • No

Special notes for reviewers:

The change should not be breaking for current implementations using UUID in x-correlator.

Changelog input

String pattern added to x-correlator scheme

Additional documentation

Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve definition of x-correlator header
4 participants