Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the headers like x-correlator be included in OAS definition? #101

Closed
rartych opened this issue Nov 24, 2023 · 4 comments · Fixed by #115
Closed

Should the headers like x-correlator be included in OAS definition? #101

rartych opened this issue Nov 24, 2023 · 4 comments · Fixed by #115
Labels
documentation Improvements or additions to documentation

Comments

@rartych
Copy link
Collaborator

rartych commented Nov 24, 2023

Problem description
Proble occured in conversation to PR #88
Currently the table in API Design Guidelines "Required in OAS Definition" states "No" for both "X-Correlator" and "X-Version"
X-Correlator header is included in some CAMARA API definitions.

In section 3.5 in relation to security related headers guidelines are:

To avoid cluttering the CAMARA OAS (Swagger) definition files, the above headers must not be included explicitly in the API definition files even when supported, as it can be assumed that developers will already be familiar with their use.

Expected action
The column "Required in OAS Definition" should rather be "Included in OAS Definition" and binding for all CAMARA APIs.
Or the whole section 9. Architecture Headers can be integrated within section 3.5.

Additional context
The more common names for header used to correlate HTTP requests between a client and server are X-Correlation-ID or Correlation-ID
https://en.wikipedia.org/wiki/List_of_HTTP_header_fields

@rartych rartych added the documentation Improvements or additions to documentation label Nov 24, 2023
@RubenBG7
Copy link
Collaborator

Hi @rartych ,

From Telefonica , we are requesting an altenative method to inform to the consumers that the x-orrelator header are available to be used in the OAS3. That's what we are waiting for... we have not received any contingency, then we are still maintaining the definition till we agree an alternative.

I Know that the x-correlator is defined in the column "Required in OAS Definition" as NO, but not required does not mean "forbidden"

Hope you know what I meaning.

@MarkCornall
Copy link
Collaborator

Whatever the solution. We must ensure operability across operators. Developers should not need to change their headers for any API to work on different operators.

@eric-murray
Copy link
Collaborator

Given that X-Correlator is not standard and requires value checking, as it must be a UUID, I think the simplest approach for both API consumers and implementors is to explicitly include this header in the OAS definition. It will not add too much clutter.

Bur X-Version should be deleted or, at least, not mandatory to include or support, as nobody seems to know what this is for.

@RubenBG7
Copy link
Collaborator

Totally agree @eric-murray to include x-correlator in OAS and delete x-version from the guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants