Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Rust edition 2018 #133

Merged
merged 2 commits into from
Jan 6, 2020
Merged

Switch to Rust edition 2018 #133

merged 2 commits into from
Jan 6, 2020

Conversation

steveej
Copy link
Contributor

@steveej steveej commented Dec 20, 2019 •
edited
Loading

Based on #136.

@steveej steveej requested a review from lucab December 20, 2019 16:30
@lucab
Copy link
Member

lucab commented Dec 20, 2019

Travis is not happy about that, but I think it's a matter of fixing a few imports.

If you haven't already, please cargo fmt this as well at the end.

@steveej
Copy link
Contributor Author

steveej commented Dec 21, 2019

Travis is not happy about that, but I think it's a matter of fixing a few imports.

I forgot to run the tests with the test-mock and test-net features. For some reason a network test times out locally, let's see what it does on travis.

lucab
lucab approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@lucab lucab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucab lucab merged commit 3b0d489 into camallo:master Jan 6, 2020
@steveej steveej deleted the pr/edition-2018 branch January 7, 2020 14:41
@steveej steveej mentioned this pull request Jul 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucab lucab lucab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steveej @lucab