Add auth subgroups #108
Add auth subgroups #108
Conversation
| @@ -38,7 +38,8 @@ | |||
|
|
|||
| # TODO: Add any additional SDK dependencies here | |||
| DEPENDENCIES = [ | |||
| 'azure-cli-core' | |||
| 'azure-cli-core', | |||
| 'azure-mgmt-appcontainers==1.0.0' | |||
There was a problem hiding this comment.
any reason we are adding the SDK here? this will install the SDK - the idea was to do this when we move to core-cli & make changes to use SDK
There was a problem hiding this comment.
@StrawnSC I see you already merged this - please remove the SDK pkg added to the dependency. I see my above comment got ignored since this was marked resolved originally
|
could you also add info on this feature to the history.rst entry? |
…ods. Added comments to separate auth params, ignored disable_max_length on secrets. Use stable_api_version for client instead of hardcoding. Remove is_preview from containerapp main command group. Added flag to disable max secret length. Removed pylint disable unused-argument comments. Refactored some code.
| with self.command_group('containerapp auth openid-connect', client_factory=auth_config_client_factory) as g: | ||
| g.custom_show_command('show', 'get_openid_connect_provider_settings') | ||
| g.custom_command('add', 'add_openid_connect_provider_settings', exception_handler=ex_handler_factory()) | ||
| g.custom_command('update', 'update_openid_connect_provider_settings', exception_handler=ex_handler_factory()) |
There was a problem hiding this comment.
Curious any reason this sub-group alone has add & remove?
There was a problem hiding this comment.
All the other providers are unique (one per CA) except for providers, so there is no way of updating them if the provider name changes, since that will be considered a different identity provider. That's my understanding of it anyways, I tried to follow the webapp spec as much as possible.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.