-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom icon aspect ratio #39
Comments
Hey, thanks for opening the issue. Does it also occur on Android? |
I'm having a hard time testing Android, see my other issue. |
Hey, the issue with low resolution should be fixed in 0.0.10 let me know if it works for you 😄 |
Thanks for checking it out @fredrikburmester, changed issue title to add this as a new feature, currently the icon size is a constant. We should either allow for specifying icon size or fix the aspect ratio |
Edit: I think this can be fixed by adjusting this property: https://github.com/okwasniewski/react-native-bottom-tabs/blob/9f0f34b53270b830b43cde7ee6bdb63f1651bb17/ios/TabViewProvider.swift#L119 It's currently set to RCTResizeMode.contain changing this should fix the issue |
See difference between sfSymbol and PNG image of same icon. It's very clear when looking at a real device.
PNG Icon is rendered at point size 200 with pixel size 10x.
The icon is also rendered incorrectly (too large)
My code
The text was updated successfully, but these errors were encountered: