Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: positional boolean arguments are an endless source of bugs and confusion. I'd suggest changing that API to take an options object, even if it only has a single option at this time. #138

Open
grabbou opened this issue Dec 16, 2024 · 3 comments

Comments

@grabbou
Copy link
Collaborator

grabbou commented Dec 16, 2024

          Positional boolean arguments are an endless source of bugs and confusion. I'd suggest changing that API to take an options object, even if it only has a single option at this time.
const state = await teamwork(workflow, prevState, { executeTools: false })

Originally posted by @kraenhansen in #130 (comment)

@kraenhansen
Copy link
Contributor

Alternatively, turned around to a positive proposition:

const state = await teamwork(workflow, prevState, { skipTools: true })

@grabbou
Copy link
Collaborator Author

grabbou commented Dec 16, 2024

No pun intended @kraenhansen ofc, skip.tools XD

@kraenhansen
Copy link
Contributor

Honestly didn't cross my mind 🙂

@pkarw pkarw changed the title Positional boolean arguments are an endless source of bugs and confusion. I'd suggest changing that API to take an options object, even if it only has a single option at this time. refactor: positional boolean arguments are an endless source of bugs and confusion. I'd suggest changing that API to take an options object, even if it only has a single option at this time. Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants