-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion: RNTL v13 breaking changes #1505
Comments
Getting in line with RN official support makes sense if there are breaking changes necessary |
Also agree with those two. We could also change the type of |
I agree as well :) |
@pierrezimmermannbam @MattAgn added point about accessible |
@pierrezimmermannbam @MattAgn @AugustinLF added point about removing deprecated queries |
Closng in favor of #1698 |
Compatibility
React 19
The v13 release will most likely happen for React 19 release for React Native. See #1593 for more info.
RN versions support
Drop support for older versions of React Native versions - perhaps in line with supported RN version (0.70 atm). We should have clear information about supported RN versions and corresponding RNTL versions.The reasoning behind is that support for older versions for RN requires additional checks and testing that would reduce our capacity to do more useful stuff and that the users on older version of RN should generally update their RN version first and only after that RNTL version.this also includes dropping React 17 supportDrop support for React 18 and lower, and focus just on React 19.
This will require introduction of versioned documentation.
Using JSX transform
Based on #1492, we could use modern JSX transform by default. We should however assess that it would work with all supported RN versions.
Remove deprecated stuff
getByAccessibilityState
,getByAccessibilityValue
- already marked as deprecatedgetByA11yHint
andgetByAccessibilityHint
and keep only one name:getByHintText
API improvements
role
value for*byRole
queries to RN-supported roles Update ByRole queries to only accept roles #1527.*ByRole
with the newtoHaveAccessibleName
matcher. Basically, if element has explicit label (aria-label
,accessibilityLabel
,aria-labelledby
,accessibilityLabelledBy
) themname
should match only that, and name derived from text content should be used only in the absence of explicit label.The text was updated successfully, but these errors were encountered: