Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the custom jest preset be deprecated? #1307

Closed
roryabraham opened this issue Feb 8, 2023 · 4 comments
Closed

Should the custom jest preset be deprecated? #1307

roryabraham opened this issue Feb 8, 2023 · 4 comments
Labels
question Further information is requested

Comments

@roryabraham
Copy link

Ask your Question

I see that the custom jest preset which does not override promise was added in response to this upstream issue. Now that that issue has been resolved upstream in facebook/react-native@f1fdc8b and released in v0.71.2, should we update documentation in this repo to deprecate the custom jest preset and only recommend it to developers using "modern fake timers" and RN < 0.71.2 ?

@mdjastrzebski
Copy link
Member

@roryabraham that's a good question. We will have to review it. However, it seems fairly low prio, so it might take a will to handle it.

@pierrezimmermannbam
Copy link
Collaborator

Oh I hadn't seen that promise was no longer polyfilled that's great news! I think it's worth mentioning in the readme that it's no longer needed for RN >= 0.71.2, I'll open a PR to update the readme

@thymikee
Copy link
Member

I wouldn't deprecate it, but treat as a proxy to original preset. When we need to add something custom, we can do it without much work from the users

@mdjastrzebski
Copy link
Member

Resolved in #1316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants