Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: coordination of recent A11y and element tree changes/proposal #1164

Closed
4 of 7 tasks
mdjastrzebski opened this issue Oct 8, 2022 · 3 comments
Closed
4 of 7 tasks

Comments

@mdjastrzebski
Copy link
Member

mdjastrzebski commented Oct 8, 2022

Recently we have a lot of activity related to accessibility as well as composite/host elements handling. All of these propositions seem to move RNTL into right direction due to more expressive queries (*ByRole), better matching accessibility behaviour of RN/iOS/Android, and increasing compatibility with RTL/DTL. However, the number of changes is getting high, some of which might be breaking changes as well, so we should do some planning in terms of minor/major releases.

My initial proposal is as follows:

Next minor or patch releases (v11.x.y) - non breaking changes

Next major release (v12.0.0)

Other PRs in the pipeline are not related to a11y/element tree and do not introduce breaking changes, so we might merge them at any moment, perhaps for minor release if they are production ready. I did not include them here to reduce complexity of the discussion.

@thymikee @AugustinLF @pierrezimmermannbam does that above plan for upcoming releases seems reasonable for you, would you want to include some more features/fixes or exclude anything mentioned above. Looking forward for your feedback.

@AugustinLF
Copy link
Collaborator

We've also had two valuable PR things merged since last release:

Overall, I'm a proponent of releasing minor/patches as often as needed (as long as the release process is not too much of a burden). So I don't feel very strongly on bundling PRs together. For instance, if we get #1130 done before any breaking change, I'd suggest to release it!

@mdjastrzebski
Copy link
Member Author

@AugustinLF I agree on releasing minor/patches more frequently, so I've updated the original description to make that clear. What was my intention is to band breaking changes with common a11y/element tree theme into one single major release, instead of triggering a higher number of major releases.

@mdjastrzebski
Copy link
Member Author

Closing as no longer relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants