You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Recently we have a lot of activity related to accessibility as well as composite/host elements handling. All of these propositions seem to move RNTL into right direction due to more expressive queries (*ByRole), better matching accessibility behaviour of RN/iOS/Android, and increasing compatibility with RTL/DTL. However, the number of changes is getting high, some of which might be breaking changes as well, so we should do some planning in terms of minor/major releases.
My initial proposal is as follows:
Next minor or patch releases (v11.x.y) - non breaking changes
Other PRs in the pipeline are not related to a11y/element tree and do not introduce breaking changes, so we might merge them at any moment, perhaps for minor release if they are production ready. I did not include them here to reduce complexity of the discussion.
@thymikee@AugustinLF@pierrezimmermannbam does that above plan for upcoming releases seems reasonable for you, would you want to include some more features/fixes or exclude anything mentioned above. Looking forward for your feedback.
The text was updated successfully, but these errors were encountered:
Overall, I'm a proponent of releasing minor/patches as often as needed (as long as the release process is not too much of a burden). So I don't feel very strongly on bundling PRs together. For instance, if we get #1130 done before any breaking change, I'd suggest to release it!
@AugustinLF I agree on releasing minor/patches more frequently, so I've updated the original description to make that clear. What was my intention is to band breaking changes with common a11y/element tree theme into one single major release, instead of triggering a higher number of major releases.
Recently we have a lot of activity related to accessibility as well as composite/host elements handling. All of these propositions seem to move RNTL into right direction due to more expressive queries (
*ByRole
), better matching accessibility behaviour of RN/iOS/Android, and increasing compatibility with RTL/DTL. However, the number of changes is getting high, some of which might be breaking changes as well, so we should do some planning in terms of minor/major releases.My initial proposal is as follows:
Next minor or patch releases (v11.x.y) - non breaking changes
states
in*ByRole
querieshidden: true
, i.e. having same default behaviour as current queries (resolves Provide query option to respect accessibility #970)*ByA11yState
query ignores default state values of false #1165) bug: *ByA11yState query ignores default state values of falseNext major release (v12.0.0)
hidden: false
to match default DTL/RTL defaultaccessible
prop on*ByRole
+hidden
,inInaccessible
, etc #1163 ignoreaccessible={true}
children whenhidden: false
, potentially fixes Querying by role with name on nested touchables return multiple elements #1152*ByText
and*ByDisplayValue
,*ByPlaceholder
to return host components instead of exported compositeText
,TextInput
Other PRs in the pipeline are not related to a11y/element tree and do not introduce breaking changes, so we might merge them at any moment, perhaps for minor release if they are production ready. I did not include them here to reduce complexity of the discussion.
@thymikee @AugustinLF @pierrezimmermannbam does that above plan for upcoming releases seems reasonable for you, would you want to include some more features/fixes or exclude anything mentioned above. Looking forward for your feedback.
The text was updated successfully, but these errors were encountered: