Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"new architecture" touch is very inconsistent for TextInput and Button (both RN and Paper) #4517

Closed
kferch-teamworks opened this issue Oct 2, 2024 · 6 comments
Labels

Comments

@kferch-teamworks
Copy link

Current behaviour

I'm starting a mobile app for my company and am using expo v51, react-native v75, react-navigation (v7 rc), and react-native-paper v5. I turned "new architecture" on because I'm just starting and I want to smoothly switch to RN 76 when it comes out by verifying that I'm not doing anything that would not work with new architecture. I noticed in my eas preview builds that on real android phones I couldn't even press buttons or bring up the keyboard in text input. It all works fine an ios phones and emulators and simulators.

I turned off "new architecture" and android phones work fine. I'm worried that with RN 76 already hitting RC that this problem hasn't been solved yet.

I built up a minimal repo and things worked fine until adding in react-navigation.

I had posted on expo and someone there actually debugged and found this:

"this looks like an interaction between react-native-screens and react-native-paper's button component. i investigated this a bit and traced it back to this single line:

{...(isV3 && { elevation: elevation })}

if you comment that out, it fixes all other touches"

Expected behaviour

How to reproduce?

Minimal repo: https://github.com/kferch-teamworks/RNAndroidTouch

Preview

What have you tried so far?

Your Environment

software version
ios x
android x
react-native x.x.x
react-native-paper x.x.x
node x.x.x
npm or yarn x.x.x
expo sdk x.x.x
@WoLewicki
Copy link

Hey, does the issue only appear when using react-navigation v7? Or is it also there on v6?

@cortinico
Copy link

Hey, does the issue only appear when using react-navigation v7? Or is it also there on v6?

cc @brentvatne

@brentvatne
Copy link
Contributor

@WoLewicki @cortinico - i just tried the repository shared by op and moved it to react-navigation v6, same issue in both cases.

@coado
Copy link

coado commented Oct 9, 2024

Hey, this is something that was fixed in this PR. If you use react-navigation v7 you can upgrade react-native-screens to 4.0.0-beta.7 version, which includes this fix. It solves the issue for provided repro.

@kferch-teamworks
Copy link
Author

Hey, this is something that was fixed in this PR. If you use react-navigation v7 you can upgrade react-native-screens to 4.0.0-beta.7 version, which includes this fix. It solves the issue for provided repro.

That sounds great. I'll check it out. Thank you.

@kferch-teamworks
Copy link
Author

I tested my android phone with eas build react-navigation v7 and screens 4.0.0-beta.7 and it worked. Closing this issue. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants