feat: exported Icon component #4014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @sangamesh1439, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
lukewalczak
changed the title
lukewalczak
changed the title
|
Love it, please guys review this, super useful |
lukewalczak
added
the
Icon
lukewalczak
reviewed
Sep 7, 2023
| * export default MyComponent; | ||
| * ``` | ||
| */ | ||
|
|
||
| const Icon = ({ |
There was a problem hiding this comment.
Could you please add some unit tests for Icon component?
lukewalczak
reviewed
Sep 7, 2023
|
|
||
| import ScreenWrapper from '../ScreenWrapper'; | ||
|
|
||
| const IconExample = () => { |
There was a problem hiding this comment.
It's worth to present examples supporting different types values, according to the icons doc
lukewalczak
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3979
Exported Icon component, added example and docs for the same.
Summary
Test plan
Tested by creating example.