-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: exported Icon component #4014
feat: exported Icon component #4014
Conversation
Hey @sangamesh1439, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
Love it, please guys review this, super useful |
* export default MyComponent; | ||
* ``` | ||
*/ | ||
|
||
const Icon = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add some unit tests for Icon
component?
|
||
import ScreenWrapper from '../ScreenWrapper'; | ||
|
||
const IconExample = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's worth to present examples supporting different types values, according to the icons doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going add unit tests and adjust the example in the follow up PR. Thanks!
Fixes: #3979
Exported Icon component, added example and docs for the same.
Summary
Test plan
Tested by creating example.