-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actually compile the library before publishing #397
Comments
Just to clarify, I don't think this is urgent or blocking. Anyone using webpack can add this to their rules: {
test: /\.js$/,
enforce: "pre",
use: [ "remove-flow-types-loader" ],
include: nodeModule('react-native-paper')
} |
I am trying to use this with React Native Web and it keeps failing with I can't figure out how to make it work. |
@rosswaycaster you're using the const path = require('path')
const fs = require('fs')
const appDirectory = fs.realpathSync(process.cwd());
const resolveApp = relativePath => path.resolve(appDirectory, relativePath)
const nodeModule = mod => resolveApp(`node_modules/${mod}`) |
Hello 👋, this issue has been open for more than 2 months with no activity on it. If the issue is still present in the latest version, please leave a comment within 7 days to keep it open, otherwise it will be closed automatically. If you found a solution on workaround for the issue, please comment here for others to find. If this issue is critical for you, please consider sending a pull request to fix the issue. |
Apparently this issue is no longer relevant because they switched to typescript from version 3 https://github.com/callstack/react-native-paper/releases/tag/v3.0.0 |
Current behaviour
Build systems that don't have flow (e.g. typescript) can't consume this module
Expected behaviour
module should be consumable as vanilla js, and perhaps have additional shadow .js.flow files alongside the distribution
The text was updated successfully, but these errors were encountered: