-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Label miss-alignment issue after upgrading to latest Expo (39) #2254
Comments
Couldn't find version numbers for the following packages in the issue:
Can you update the issue to include version numbers for those packages? The version numbers must match the format 1.2.3. The versions mentioned in the issue for the following packages differ from the latest versions on npm:
Can you verify that the issue still exists after upgrading to the latest versions of these packages? |
@hamedmam It is actually worse than that for react-native-web https://snack.expo.io/Hv98xiEmj (react-native-paper 4.2.0, react-native-web 0.13.13 and expo 39) the input text is completely hidden. I have tracked the cause of it, it is to do with the changes in how the ref is handled via this commit necolas/react-native-web@376ccc3 by @necolas |
@hamedmam if you are using react-native-web 0.13.13 and expo 39 you can use the patch https://gist.github.com/cj/4d5e2494a0510b3185d38db936d2a297 with https://www.npmjs.com/package/patch-package as a quick fix for now. |
File a bug |
@necolas opened one up necolas/react-native-web#1749 |
I'll need a reduced test case as this package is a hassle to run on web due to its dependencies |
There is a similar issue with the banner in this line: react-native-paper/src/components/Banner.tsx Line 184 in efe17be
When |
@jaulz is there going to be a patch soon? This broke all of my banners across the entire app. |
This problem should be fixed in react native for web 0.13.14. Ref memoization shouldn't change behavior but I don't yet understand why it did here. If you're running this lib on web you should know that there are several accessibility and performance issues with the implementation here though. |
@necolas Yes, Thank you upgrading to 0.13.14 fixed my issue. I'm aware of some of the issues running this lib on the web. I've been working around the issues as I find them. Thank you. |
Hello 👋, this issue has been open for more than 2 months with no activity on it. If the issue is still present in the latest version, please leave a comment within 7 days to keep it open, otherwise it will be closed automatically. If you found a solution on workaround for the issue, please comment here for others to find. If this issue is critical for you, please consider sending a pull request to fix the issue. |
Current behaviour
Label is not in the center of input field and after focus it is not placed in the middle of top line
Expected behaviour
Having the the label in the center of input vertically and in the center of top line of input field
Code sample
N/A
Screenshots (if applicable)
What have you tried
tried upgrading to version 4.2.0 and it is the same
Your Environment
The text was updated successfully, but these errors were encountered: