Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extern files for the google closure compiler #3119

Closed
nha opened this issue Jan 31, 2016 · 4 comments
Closed

extern files for the google closure compiler #3119

nha opened this issue Jan 31, 2016 · 4 comments
Labels
discussion new feature New feature or request

Comments

@nha
Copy link

nha commented Jan 31, 2016

[feature request]

I would like to use material-ui, and in my toolchain I use the google closure compiler, which does dead-code elimination and renames things. To prevent it from renaming we have to have .extern.js files.

This is a bit tedious at first, but it allows shipping only the code that is being used. It would also allow to use material-ui from ClojureScript (which uses the google closure compiler).

Could it be an option to add these files to material-ui ?

@alitaheri alitaheri added new feature New feature or request Core discussion labels Feb 1, 2016
@alitaheri
Copy link
Member

I'm not very familiar with .extern.js files. what would the contents be? Can it not be handled from user side?

@oliviertassinari
Copy link
Member

We haven't heard about since a long time. I'm closing but we are open to better support the google closure compiler.

@nenadalm
Copy link

nenadalm commented Jan 8, 2018

Hi. I just noticed that react is working on it: facebook/react#11092 so I was wondering how it is with material-ui and found this ticket.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 9, 2018

@nenadalm React is a bit different. They are publishing one big optimized javascript file. We are publishing a lot of small files (e.g. each components) that users build system have to bundle. (different story for the umd bundle)
As far as I know, you can't have tree shaking with the React publishing approach, but it's fine as they don't need it. We do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion new feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants