Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Linting #15

Closed
vigji opened this issue Jan 4, 2024 · 1 comment
Closed

[Minor] Linting #15

vigji opened this issue Jan 4, 2024 · 1 comment

Comments

@vigji
Copy link

vigji commented Jan 4, 2024

The code seems to not have been passed through any linting tool (such as flake8) to remove minor departures from PEP recommendations (eg, unused imports, unused arguments in functions). To make it publishable-quality, I would recommend including some linting tool in the workflow to iron those out.

@calebweinreb
Copy link
Owner

Thanks for the suggestion! I used black to reformat the code and VS code to highlight unused imports (which were deleted) (aee2d2a). I know some projects also include these kinds of checks as github actions but I think that might be overkill here as I am currently the only active developer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants