Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] conflation of data and GUI parameters logic #11

Closed
vigji opened this issue Jan 4, 2024 · 2 comments
Closed

[Minor] conflation of data and GUI parameters logic #11

vigji opened this issue Jan 4, 2024 · 2 comments

Comments

@vigji
Copy link

vigji commented Jan 4, 2024

I have been reading the functions for the project creation, and I am bit confused by the conflation of the (thin) data-munging logic and the visualization settings logic in the same functions.

Maybe it would be better to separate the part where one links to the project all the available data and the part where one specifies the default parameters for the GUI.

@niksirbi
Copy link

There is a related issue to that one.

As a user, I would like to be able to change visualisation parameters like vmin, vmax, colormap, linewidth etc. directly in the GUI. It's a bit weird to pre-specify these when adding data to the project, because at that point you haven't seen the data and you might not know what visualisation parameters are appropriate. Some of these parameters are editable from the GUI, but not all of them.

@calebweinreb
Copy link
Owner

The overall rationale for ingesting data and setting plotting parameters in a single function is explained here #11

It is a good point that though that users might wish to make further adjustments once the SNUB plot is already open, especially ones that could potentially impact the legibility of the plot. I just merged #28 that makes a few more parameters adjustable in the GUI:

  • scatter plot: users can now adjust marker size and border width directly in the GUI
  • trace plot: users can adjust linewidth and y-axis bounds in the GUI

These parameter changes are not saved to the config (currently the GUI never directly changes the config and I'd like to keep it that way).

@vigji vigji closed this as completed Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants