Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWT package update #17

Closed
heshanh opened this issue May 3, 2022 · 7 comments
Closed

JWT package update #17

heshanh opened this issue May 3, 2022 · 7 comments

Comments

@heshanh
Copy link

heshanh commented May 3, 2022

Hi, i was wondering if you're planning on updating firebase/php-jwt to the latest?

@sethsandaru
Copy link

bump for this

@calcinai
Copy link
Owner

calcinai commented Jul 4, 2022

Hi @heshanh & @sethsandaru apologies I haven't had a chance to test this out. Have either of you tested the latest version?

@ok200paul
Copy link

Hi, i was wondering if you're planning on updating firebase/php-jwt to the latest?

Hey @heshanh - long time no see man! Hope you're well.

Anyway @calcinai thanks for a great package, I've set up calcinai/xero-php locally with an updated symlinked repo for calcinai/oauth2-xero - I've popped in a PR #19

I forked calcinai/xero-php to https://github.com/ok200paul/xero-php and referenced my updated fork, I'm on PHP8.1 so updated the PHPUnit dep to latest, and updated the tests to work with the PHPUnit version - they look good. Likely got some BC breaks so I didn't submit a PR here, but feel free to clone and run tests in there, hopefully they prove the firebase/php-jwt bump to this new version works OK.

@Rincewindrunner
Copy link
Contributor

My colleague and I have had a look at the firebase/php-jwt changes (which don't look to impact the use cases this repo relies on the library for) and have been testing the updated version with no issues.

This and calcinai/xero-php are really helpful packages. I'm honestly surprised there hasn't been more noise on this issue - I landed here because this dependency is preventing us from updating to Laravel 9 LTS (where Laravel Passport requires the newer firebase/php-jwt version).
Would love to see it get updated here rather than also needing to fork the library in the interim.
Let me know if there is anything further we can do to help.

@calcinai
Copy link
Owner

Hey @Rincewindrunner sorry for the slow response. Feel free to make a PR from your fork and I'll merge it in.

@Rincewindrunner
Copy link
Contributor

Sorry for my glacially slow PR, I've opened #21

@calcinai
Copy link
Owner

Hey, I can be slower...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants